lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: IndexWriter.init() checks for infoStream != null, redundantly?
Date Sun, 14 Feb 2010 10:45:23 GMT
IndexWriter has a default infoStream, so the infoStream could be
non-null during init.

Mike

On Sat, Feb 13, 2010 at 3:16 PM, Shai Erera <serera@gmail.com> wrote:
> Hi
>
> IndexWriter.init() checks a couple of times whether infoStream != null in
> order to print informative messages ... init() is called only from the
> ctors, which means infoStream will always be null at this point, no?
> Therefore I think those checks can be removed? Not for performance reasons,
> but for clarity - no one should expect those messages to be printed out.
>
> BTW, would it make sense to add a ctor which accepts infoStream right from
> the start, so that such messages will be printed out?
>
> I don't think an issue is needed (to remove the checks), however if there is
> interest in adding a new ctor which accepts infoStream, then I can open one.
> Even though I don't think those messages are really critical at this stage
> of the system.
>
> Shai
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message