lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marvin Humphrey (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2282) Expose IndexFileNames as public, and make use of its methods in the code
Date Tue, 23 Feb 2010 23:08:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837499#action_12837499
] 

Marvin Humphrey commented on LUCENE-2282:
-----------------------------------------

> Any application that extends IW, or provide its own Directory
> implementation, and wants to reference Lucene's file extensions properly
> (i.e. not by putting its code under o.a.l.index or hardcoding ".del" as its
> deletions file) will benefit from making it public.

> Forgot to tag IFN as @lucene.internal 

?

If the class is tagged as "internal", then external applications like the one 
you describe above aren't supposed to use it, right?

But I don't really care about whether this goes into Lucene.  Go ahead, make
it fully public and omit the "internal" tag.  Not my problem. :)

The thing is, I really don't understand what kind of thing you want to do.
Are you writing your own deletions files?

I'm trying to understand because the only use cases I can think of for this
aren't compatible with index pluggability, which is a high priority for Lucy.

    * Sweep "non-core-Lucene files" to "clean up" an index.
    * Gather up "core-Lucene files" for export.
    * Audit "core-Lucene files" to determine whether the index is in a valid
      state.
    * Differentiate between "core-Lucene and "non-core-Lucene" files when
      writing a compound file.

Maybe there's something I haven't thought of, though.  Why do you want to
"reference Lucene's file extensions properly"?  Once you've identified
identified which files are "core Lucene" and which files aren't, what are you
going to do with them?



> Expose IndexFileNames as public, and make use of its methods in the code
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2282
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2282
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Shai Erera
>             Fix For: 3.1
>
>         Attachments: LUCENE-2282.patch, LUCENE-2282.patch
>
>
> IndexFileNames is useful for applications that extend Lucene, an in particular those
who extend Directory or IndexWriter. It provides useful constants and methods to query whether
a certain file is a core Lucene file or not. In addition, IndexFileNames should be used by
Lucene's code to generate segment file names, or query whether a certain file matches a certain
extension.
> I'll post the patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message