lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class
Date Mon, 15 Feb 2010 15:23:28 GMT


Shai Erera commented on LUCENE-1720:

Hmm ... I've added the method above, and it solved the issue in one of the tests, but revealed
other issues with FilterIndexReader, like for example it doesn't override getUniqueTermCount()
and reopen() ... so maybe we need to change the current TestFilterIndexReader  to extend TestIndexReader
and override getReader() ... this looks like a separate issue, though it will block this issue
A change in TestIndexReader is also required in one test which asserts that the instance of
the reader is DirectoryReader (or ReadOnlySegmentReader), but that's easy to do by for example
adding a isInstanceOf(IndexReader) method to TestIndexReader which will be overridden in TestFilterIndexReader
and TestTimeLimitingIndexReader.

> TimeLimitedIndexReader and associated utility class
> ---------------------------------------------------
>                 Key: LUCENE-1720
>                 URL:
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Index
>            Reporter: Mark Harwood
>            Assignee: Mark Harwood
>            Priority: Minor
>         Attachments:,,,, Lucene-1720.patch, Lucene-1720.patch, LUCENE-1720.patch,,,,
> An alternative to TimeLimitedCollector that has the following advantages:
> 1) Any reader activity can be time-limited rather than just single searches e.g. the
document retrieve phase.
> 2) Times out faster (i.e. runaway queries such as fuzzies detected quickly before last
"collect" stage of query processing)
> Uses new utility timeout class that is independent of IndexReader.
> Initial contribution includes a performance test class but not had time as yet to work
up a formal Junit test.
> TimeLimitedIndexReader is coded as JDK1.5 but can easily be undone.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message