lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2055) Fix buggy stemmers and Remove duplicate analysis functionality
Date Mon, 01 Feb 2010 12:41:51 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828079#action_12828079
] 

Robert Muir commented on LUCENE-2055:
-------------------------------------

bq. StemOverrideFilter should be final or have final incrementToken()

ok, thanks, will fix this now.

bq. The usage of mixed CharArraySet and a conventional dictionary map is buggy. The CAS is
using a different contains algo and lowercasing, you can get a hit in the CAS but the Map
returns null -> NPE. I would not use a CAS for the beginning and always cast to String
for now and I will open an issue for extending CAS to be a CharArrayMap

No. Instead i will force it to be case sensitive to ignore this, it is stilly to have dutch
stem filter be horribly slow because of some theoretical case like this.



> Fix buggy stemmers and Remove duplicate analysis functionality
> --------------------------------------------------------------
>
>                 Key: LUCENE-2055
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2055
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>             Fix For: 3.1
>
>         Attachments: LUCENE-2055.patch
>
>
> would like to remove stemmers in the following packages, and instead in their analyzers
use a SnowballStemFilter instead.
> * analyzers/fr
> * analyzers/nl
> * analyzers/ru
> below are excerpts from this code where they proudly proclaim they use the snowball algorithm.
> I think we should delete all of this custom stemming code in favor of the actual snowball
package.
> {noformat}
> /**
>  * A stemmer for French words. 
>  * <p>
>  * The algorithm is based on the work of
>  * Dr Martin Porter on his snowball project<br>
>  * refer to http://snowball.sourceforge.net/french/stemmer.html<br>
>  * (French stemming algorithm) for details
>  * </p>
>  */
> public class FrenchStemmer {
> /**
>  * A stemmer for Dutch words. 
>  * <p>
>  * The algorithm is an implementation of
>  * the <a href="http://snowball.tartarus.org/algorithms/dutch/stemmer.html">dutch
stemming</a>
>  * algorithm in Martin Porter's snowball project.
>  * </p>
>  */
> public class DutchStemmer {
> /**
>  * Russian stemming algorithm implementation (see http://snowball.sourceforge.net for
detailed description).
>  */
> class RussianStemmer
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message