lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erick Erickson <erickerick...@gmail.com>
Subject Re: Uwe's question
Date Fri, 26 Feb 2010 02:57:14 GMT
Well, "Things got busy (tm)". Uwe's point if valid; unless there's
demonstrable gain, moving things to Junit4 "just for fun" is wasted motion,
indeed dangerous. I was focusing on LocalizedTestCase to understand the
place of runBare etc. in the scheme of things since when I created
LuceneTestCaseJ4 that was something I wanted to figure out to make it a
replacement for LuceneTestCase.

I can't point to a compelling reason to shake up the code, the only
improvement it would have is having a demonstration of using the Junit4
@RunWith annotation for future reference.

So, I've no compelling reason to push that patch forward. If y'all think
it's worth it I'll be happy to crank that patch back up again, it'll take a
few days though. It does affect a several files, and if the main value here
is an exemplar of the @RunWith annotation, perhaps there's a better place to
put that in.

Erick

On Thu, Feb 25, 2010 at 9:06 PM, Robert Muir <rcmuir@gmail.com> wrote:

>
>
>
>> LocalizedTestCase called runBare in LuceneTestCase which reported the seed
>> value if an exception was thrown. I couldn't find a good way to access
>> runBare or analogs in Junit4, but the interceptor pattern worked as well.
>> The interceptor is called by the Junit framework on test events, so there
>> aren't references to it in the Lucene test code. There are other places that
>> call runBare, so I assumed that if anyone wanted to use Junit4 with those
>> classes it would be a good thing to allow.
>>
>
> I didn't forget about your patch Erick, in my opinion there is nothing
> wrong with it. I hope its not discouraging you, the problem is a few of us
> have spent countless hours trying to debug this hard-to-reproduce Thai test
> failure problem.
>
> It failed in the existing tests, too, with Junit 3 on hudson (one time!).
> At this point, i start to wonder if it could be related to stuff like this:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6683975
>
> I don't think we should let this stop progress with the tests, if you think
> we should move LocalizedTestCase to junit 4 lets do it.
>
> --
> Robert Muir
> rcmuir@gmail.com
>

Mime
View raw message