lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] Updated: (LUCENE-2037) Allow Junit4 tests in our environment.
Date Fri, 26 Feb 2010 08:00:29 GMT


Uwe Schindler updated LUCENE-2037:

    Attachment: LUCENE-2037-getName.patch

Hi Erik,

I have [after I understood the code  :-) ] rewritten the TestWatchman code to now only work
inside LuceneTestCaseJ4, no reflection use and added a startup(), that simply sets the correct
test name in the enclosing class. I see no usage in making the InterceptTestCase public, as
it is only used inside LuceneTestCaseJ4. If a subclass or localized one needs this watchman,
too, you can siply create a second one. I also made the field final.

Now the tests for random failures behave like before. I would like to commit this soon. This
change also affects the uncaught exception handler.

> Allow Junit4 tests in our environment.
> --------------------------------------
>                 Key: LUCENE-2037
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>    Affects Versions: 3.1
>         Environment: Development
>            Reporter: Erick Erickson
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 3.1
>         Attachments: junit-4.7.jar, LUCENE-2037-getName.patch, LUCENE-2037.patch, LUCENE-2037.patch,
LUCENE-2037.patch, LUCENE-2037_remove_testwatchman.patch, LUCENE-2037_revised_2.patch
>   Original Estimate: 8h
>  Remaining Estimate: 8h
> Now that we're dropping Java 1.4 compatibility for 3.0, we can incorporate Junit4 in
testing. Junit3 and junit4 tests can coexist, so no tests should have to be rewritten. We
should start this for the 3.1 release so we can get a clean 3.0 out smoothly.
> It's probably worthwhile to convert a small set of tests as an exemplar.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message