lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-2285) Code cleanup from all sorts of (trivial) warnings
Date Fri, 26 Feb 2010 17:19:28 GMT


Michael McCandless commented on LUCENE-2285:

I think the cleanup here is great (thanks Shai!).  We don't get enough
patches cleaning things up, so, they are always welcome...

And the fact that Eclipse detection of an unecessary cast lead to
catching the bug in TestCharSet/Map (not calling the method we thought
it was calling) is also great.

The move to Junit4 appears to be controversial so I agree we should
handle it separately.

I don't think difficulty merging to the flex branch really applies
here... we should try hard not to allow the existence of flex branch
to make life harder/slower on trunk.  We (well, Mark, Uwe, Robert:
thanks!) merge huge changes over to flex every so often.  And I'd like
to land flex soonish (hopefully) so we don't have to do that

Probably we shouldn't change generated code unless really necessary?
I think it can just cause confusion down the road when someone (not
us) generates and then is baffled why all these new Eclipse warnings
appeared?  In fact, I think, ideally, our build would always regen all
gen'd code.  This way if we screw up by accidentally editing only the
gen'd code and not the source (which I've done, at least 2 or 3
times!!), we find out quickly... it'd keep us honest.

I think it doesn't matter one way or another if we do the
TEST_VERSION_CURRENT cutover here or under the existing issue.  Looks
like Uwe will be committing both, anyway ;)

> Code cleanup from all sorts of (trivial) warnings
> -------------------------------------------------
>                 Key: LUCENE-2285
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Shai Erera
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.1
>         Attachments: LUCENE-2285.patch, LUCENE-2285.patch
> I would like to do some code cleanup and remove all sorts of trivial warnings, like unnecessary
casts, problems w/ javadocs, unused variables, redundant null checks, unnecessary semicolon
etc. These are all very trivial and should not pose any problem.
> I'll create another issue for getting rid of deprecated code usage, like LuceneTestCase
and all sorts of deprecated constructors. That's also trivial because it only affects Lucene
code, but it's a different type of change.
> Another issue I'd like to create is about introducing more generics in the code, where
it's missing today - not changing existing API. There are many places in the code like that.
> So, with you permission, I'll start with the trivial ones first, and then move on to
the others.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message