lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Harwood (JIRA)" <>
Subject [jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class
Date Mon, 15 Feb 2010 15:59:28 GMT


Mark Harwood commented on LUCENE-1720:

bq. BTW found and fixed a bug in TimeLimitingIndexReader.reopen which returned the wrapped
reopened instance if it wasn't changed, instead of itself

Good catch.

bq. We can get over that by offering a protected getNewInstance(IndexReader) which will be
overridden by sub-classes

Would that be abstract? That would effectively help force subclasses to do the right thing
when reopening but introduce a back-compatibility issue.
If we don't make it abstract what would be the default implementation of this method?
Maybe it's all best handled by simply adding a note saying "you really should think about
overriding reopen" in FilterIndexReader's javadocs?

> TimeLimitedIndexReader and associated utility class
> ---------------------------------------------------
>                 Key: LUCENE-1720
>                 URL:
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Index
>            Reporter: Mark Harwood
>            Assignee: Mark Harwood
>            Priority: Minor
>         Attachments:,,,, Lucene-1720.patch, Lucene-1720.patch, LUCENE-1720.patch,,,,
> An alternative to TimeLimitedCollector that has the following advantages:
> 1) Any reader activity can be time-limited rather than just single searches e.g. the
document retrieve phase.
> 2) Times out faster (i.e. runaway queries such as fuzzies detected quickly before last
"collect" stage of query processing)
> Uses new utility timeout class that is independent of IndexReader.
> Initial contribution includes a performance test class but not had time as yet to work
up a formal Junit test.
> TimeLimitedIndexReader is coded as JDK1.5 but can easily be undone.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message