lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2190) CustomScoreQuery (function query) is broken (due to per-segment searching)
Date Sun, 21 Feb 2010 16:53:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836396#action_12836396
] 

Michael McCandless commented on LUCENE-2190:
--------------------------------------------

Patch looks good!

Only thing is I think we should revert this:
{code}
@@ -382,7 +387,7 @@
 
     @Override
     public boolean scoresDocsOutOfOrder() {
-      return false;
+      return subQueryWeight.scoresDocsOutOfOrder();
     }
{code}

We need to return false from here because CSQ always scores in order (it asks the sub scorers
for in-order scorers).

> CustomScoreQuery (function query) is broken (due to per-segment searching)
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-2190
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2190
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9, 2.9.1, 3.0, 3.0.1, 3.1
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 2.9.2, 3.0.1, 3.1
>
>         Attachments: LUCENE-2190-2.patch, LUCENE-2190-2.patch, LUCENE-2190.patch
>
>
> Spinoff from here:
>   http://lucene.markmail.org/message/psw2m3adzibaixbq
> With the cutover to per-segment searching, CustomScoreQuery is not really usable anymore,
because the per-doc custom scoring method (customScore) receives a per-segment docID, yet
there is no way to figure out which segment you are currently searching.
> I think to fix this we must also notify the subclass whenever a new segment is switched
to.  I think if we copy Collector.setNextReader, that would be sufficient.  It would by default
do nothing in CustomScoreQuery, but a subclass could override.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message