lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2282) Expose IndexFileNames as public, and make use of its methods in the code
Date Tue, 23 Feb 2010 21:29:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837455#action_12837455
] 

Shai Erera commented on LUCENE-2282:
------------------------------------

bq. What are the applications that we are trying to support by exposing this API?

Any application that extends IW, or provide its own Directory implementation, and wants to
reference Lucene's file extensions properly (i.e. not by putting its code under o.a.l.index
or hardcoding ".del" as its deletions file) will benefit from making it public.
The class already exists, and declares the right constants and methods. All I want is to expose
it as public. This information is not *hidden*, it's out there. We're just making it easier
for apps to reference it.

Like Mike mentioned on the java-dev thread http://old.nabble.com/IndexFileNames-td27699103.html,
he exposes it (or a variant) on the flex branch as public, because classes outside the 'index'
package need to reference it. Indeed once Flex is out, that file will need to change or extend
to accommodate pluggable index formats / files, but that's not the matter of this issue. This
issue is just about exposing an already existing class as public instead of package-private
for convenience ...

> Expose IndexFileNames as public, and make use of its methods in the code
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2282
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2282
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Shai Erera
>             Fix For: 3.1
>
>         Attachments: LUCENE-2282.patch
>
>
> IndexFileNames is useful for applications that extend Lucene, an in particular those
who extend Directory or IndexWriter. It provides useful constants and methods to query whether
a certain file is a core Lucene file or not. In addition, IndexFileNames should be used by
Lucene's code to generate segment file names, or query whether a certain file matches a certain
extension.
> I'll post the patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message