lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class
Date Fri, 12 Feb 2010 06:07:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832858#action_12832858
] 

Shai Erera commented on LUCENE-1720:
------------------------------------

Thanks Mark. I will take a look at the patch a bit later. TestActivityMonitor should move
to o.a.l.util as well. I can do that.
I also want to experiment w/ using ConcurrentHashMap, as most of the times the map is just
checked and not modified. I'll see if it removes some of the synchronization. The synchronization
is needed because of TimeoutThread, which only checks the map ... if it's possible, I believe
it will improve the performance of ATM.

About adding it to IndexReader directly - it'd be interesting to see if it affects performance
in any way, but I wouldn't want to see it directly in IR, since if I don't want to limit anything,
I don't want to add an 'if' everywhere in IR, or a call to ATM ... it'd be interesting to
see if it improves anything though.

I also want to add a TestTimeLimitedIndexReader.

BTW about the name - I think TimeLimitingIndexReader is more accurate, since it's not the
IR which is time limited, but the operations it performs. What do you think? (also we'll follow
TimeLimitingCollector) ...

> TimeLimitedIndexReader and associated utility class
> ---------------------------------------------------
>
>                 Key: LUCENE-1720
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1720
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Index
>            Reporter: Mark Harwood
>            Assignee: Mark Harwood
>            Priority: Minor
>         Attachments: ActivityTimedOutException.java, ActivityTimeMonitor.java, ActivityTimeMonitor.java,
ActivityTimeMonitor.java, Lucene-1720.patch, LUCENE-1720.patch, TestTimeLimitedIndexReader.java,
TestTimeLimitedIndexReader.java, TimeLimitedIndexReader.java, TimeLimitedIndexReader.java
>
>
> An alternative to TimeLimitedCollector that has the following advantages:
> 1) Any reader activity can be time-limited rather than just single searches e.g. the
document retrieve phase.
> 2) Times out faster (i.e. runaway queries such as fuzzies detected quickly before last
"collect" stage of query processing)
> Uses new utility timeout class that is independent of IndexReader.
> Initial contribution includes a performance test class but not had time as yet to work
up a formal Junit test.
> TimeLimitedIndexReader is coded as JDK1.5 but can easily be undone.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message