lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2285) Code cleanup from all sorts of (trivial) warnings
Date Thu, 25 Feb 2010 07:22:27 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838219#action_12838219
] 

Uwe Schindler commented on LUCENE-2285:
---------------------------------------

bq. I'll create another issue for getting rid of deprecated code usage, like LuceneTestCase
and all sorts of deprecated constructors. 

At the moment this is not simple, as there are LocalizedTestCase which is not easy to transform
to JUnit4. In my opinion, the deprecation of the TestCase base class should be reverted. And
also most people here (inlcuding me) are not willing to add these stupid @Test everywhere
when writing tests, so we only transform testcases that would speedup with @BeforeClass, @AfterClass
(creating a read-only index only one time per class, e.g. see NRQ tests).

About the @SuppressWarnings: These are some from other compilers, a Java compiler is required
to ignore all unknown ones, so they dont hurt. But for cleanness, we only want to have Sun
javac compile annotations and of course @Override (not for interfaces, Java 1.5!) + @Deprecated.

bq. Another issue I'd like to create is about introducing more generics in the code, where
it's missing today - not changing existing API

Which places do you mean? The public apis are 100% generics, maybe some internal parts. Some
additional requirement: Please avoid autoboxing!

If you cleanup the code use in all cases the Eclipse code style from the Wiki (contributor
page). We have an updated one with generics support!!!

> Code cleanup from all sorts of (trivial) warnings
> -------------------------------------------------
>
>                 Key: LUCENE-2285
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2285
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Shai Erera
>            Priority: Minor
>             Fix For: 3.1
>
>
> I would like to do some code cleanup and remove all sorts of trivial warnings, like unnecessary
casts, problems w/ javadocs, unused variables, redundant null checks, unnecessary semicolon
etc. These are all very trivial and should not pose any problem.
> I'll create another issue for getting rid of deprecated code usage, like LuceneTestCase
and all sorts of deprecated constructors. That's also trivial because it only affects Lucene
code, but it's a different type of change.
> Another issue I'd like to create is about introducing more generics in the code, where
it's missing today - not changing existing API. There are many places in the code like that.
> So, with you permission, I'll start with the trivial ones first, and then move on to
the others.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message