lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shai Erera <ser...@gmail.com>
Subject NoLockFactory does not have a private ctor
Date Wed, 02 Dec 2009 12:10:42 GMT
NoLockFactory documents in its javadocs that one should call the static
getNoLockFactory() in order to create an instance. The class however does
not have a private ctor, so someone can create another instance of it. This
is not a big deal though, because makeLock returns a static member. But it
looks like this class should follow the singleton pattern, however doesn't.

Looks an easy fix to me. Can someone commit it, or do we need an issue?

Shai

Mime
View raw message