lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wettin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2144) InstantiatedIndexReader does not handle #termDocs(null) correct (AllTermDocs)
Date Thu, 10 Dec 2009 23:30:18 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789021#action_12789021
] 

Karl Wettin commented on LUCENE-2144:
-------------------------------------

Committed change to trunk.

In 3.0 comment out ~line 227 in TestIndicesEquals

    // this is invalid use of the API,
    // but if the response differs then it's an indication that something might have changed.
    // in 2.9 and 3.0 the two TermDocs-implementations returned different values at this point.
    assertEquals("Descripency during invalid use of the TermDocs API, see comments in test
code for details.",
        aprioriTermDocs.next(), testTermDocs.next());


> InstantiatedIndexReader does not handle #termDocs(null) correct (AllTermDocs)
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-2144
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2144
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/*
>    Affects Versions: 2.9, 2.9.1, 3.0
>            Reporter: Karl Wettin
>            Assignee: Michael McCandless
>            Priority: Critical
>         Attachments: LUCENE-2144-30.patch, LUCENE-2144.txt
>
>
> This patch contains core changes so someone else needs to commit it.
> Due to the incompatible #termDocs(null) behaviour at least MatchAllDocsQuery, FieldCacheRangeFilter
and ValueSourceQuery fails using II since 2.9.
> AllTermDocs now has a superclass, AbstractAllTermDocs that also InstantiatedAllTermDocs
extend.
> Also:
>  * II-tests made less plausable to pass on future incompatible changes to TermDocs and
TermEnum
>  * IITermDocs#skipTo and #next mimics the behaviour of document posisioning from SegmentTermDocs#dito
when returning false
>  * II now uses BitVector rather than sets for deleted documents

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message