lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-2108) SpellChecker file descriptor leak - no way to close the IndexSearcher used by SpellChecker internally
Date Fri, 04 Dec 2009 12:30:20 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Simon Willnauer updated LUCENE-2108:
------------------------------------

    Attachment: LUCENE-2108.patch

This patch adds a close operation to SpellChecker and enables thread-safety.
I added a testcase for concurrency as well as the close method - comments and review welcome!

> SpellChecker file descriptor leak - no way to close the IndexSearcher used by SpellChecker
internally
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2108
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2108
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/spellchecker
>    Affects Versions: 3.0
>            Reporter: Eirik Bjorsnos
>            Assignee: Simon Willnauer
>             Fix For: 3.0.1, 3.1
>
>         Attachments: LUCENE-2108-SpellChecker-close.patch, LUCENE-2108.patch, LUCENE-2108.patch
>
>
> I can't find any way to close the IndexSearcher (and IndexReader) that
> is being used by SpellChecker internally.
> I've worked around this issue by keeping a single SpellChecker open
> for each index, but I'd really like to be able to close it and
> reopen it on demand without leaking file descriptors.
> Could we add a close() method to SpellChecker that will close the
> IndexSearcher and null the reference to it? And perhaps add some code
> that reopens the searcher if the reference to it is null? Or would
> that break thread safety of SpellChecker?
> The attached patch adds a close method but leaves it to the user to
> call setSpellIndex to reopen the searcher if desired.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message