lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] Commented: (LUCENE-2111) Wrapup flexible indexing
Date Fri, 04 Dec 2009 08:03:20 GMT


Uwe Schindler commented on LUCENE-2111:

I Mike,

maybe I found an issue in LegacyFieldsEnum & Co:

- The LegacyTermsEnum correctly seeks to the first Term/TermRef but as the deprec TermEnum
still iterates after the last term, the TermsEnum returns all terms from all later fields,
too. So seek() and next() should also do a field==Term.field() comparison and set SeekStatus/return
value correctly.
- Also (you see it because missing @Override): The new Enums have no close method / not implement, so the underlying old enums are never closed by client code. Shouldn't
all the enum classes not also be Closeable, even when the new Codec API current would implement
these as a no-op for core classes. But maybe someone creates a codec that needs close?

> Wrapup flexible indexing
> ------------------------
>                 Key: LUCENE-2111
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: Flex Branch
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.1
> Spinoff from LUCENE-1458.
> The flex branch is in fairly good shape -- all tests pass, initial search performance
testing looks good, it survived several visits from the Unicode policeman ;)
> But it still has a number of nocommits, could use some more scrutiny especially on the
"emulate old API on flex index" and vice/versa code paths, and still needs some more performance
testing.  I'll do these under this issue, and we should open separate issues for other self
contained fixes.
> The end is in sight!

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message