Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <1871678386.1258190319569.JavaMail.jira@brutus>
Date: Sat, 14 Nov 2009 09:18:39 +0000 (UTC)
From: "Robert Muir (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-2052) Scan method signatures and add
 varargs where possible
In-Reply-To: <765845245.1257897147848.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777846#action_12777846 ] 

Robert Muir commented on LUCENE-2052:
-------------------------------------

bq. Thanks, I didn't check contrib.

I didn't really completely check, not sure really where we should have varargs there.
(it does not make sense for stopwords to me, but then I feel all we need is Set<?> instead of file, varargs, hashtable, and all the other constructors we have)

still i'd rather have consistency for now.

> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
>                 Key: LUCENE-2052
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2052
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.0
>
>         Attachments: LUCENE-2052.patch, LUCENE-2052.patch, LUCENE-2052_fa.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org