Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <17032091.1258191100155.JavaMail.jira@brutus>
Date: Sat, 14 Nov 2009 09:31:40 +0000 (UTC)
From: "Uwe Schindler (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-2052) Scan method signatures and add
 varargs where possible
In-Reply-To: <765845245.1257897147848.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777851#action_12777851 ] 

Uwe Schindler commented on LUCENE-2052:
---------------------------------------

Yes, that's right. For stopwords a varargs ctor is not really "the right thing". Varargs are more for cases like instantiating a MultiReader with 5 IndexReaders or something like that. Or adding a bunch of clauses to a SpanQuery.
The varargs Set<?> is one unit, arrays are not needed (they are there because of BW compatibility). All these ctors except Set<?> should have been deprecated in 2.9.

> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
>                 Key: LUCENE-2052
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2052
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.0
>
>         Attachments: LUCENE-2052.patch, LUCENE-2052.patch, LUCENE-2052_fa.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org