Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <1585933709.1258681479892.JavaMail.jira@brutus>
Date: Fri, 20 Nov 2009 01:44:39 +0000 (UTC)
From: "Erick Erickson (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-2037) Allow Junit4 tests in our
 environment.
In-Reply-To: <1530679812.1257468812606.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780368#action_12780368 ] 

Erick Erickson commented on LUCENE-2037:
----------------------------------------

Well, last night I changed LocalizedTestCase to do the @RunWith and
@Parameterized thing and it works just fine with a minimal change to
subclasses, mainly adding @Test and a c'tor with a Locale parameter. Total,
it adds probably a minute to the test run.

About the cross product of versions and locales. The @Parameterized thingy
returns a list of Object[], where the elements of the list are matched
against a c'tor. So if each object[] in your list has, say, an (int, float,
int), then as long as you have a matching c'tor with a signature that takes
an (int, float, int) you're good to go. So to handle the mXn case you
mentioned, if your @Parameters method returned a list of object[], one
object[] for each <Locale, Version> pair, you'd get all your Locales run
against all your versions.

Whether we *want* this to happen or not is another question. It's a
worthwhile question whether we really *need* to run all the possible locales
or if there's a subset of locales that would serve.

It's kind of ironic that I have a patch waiting to be applied that cuts down
on the time it takes to run the unit tests and another patch that adds to
the time it takes. Two steps forward, one step back and a jink sideways just
for fun.....

Best
Erick


> Allow Junit4 tests in our environment.
> --------------------------------------
>
>                 Key: LUCENE-2037
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2037
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>    Affects Versions: 3.1
>         Environment: Development
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: junit-4.7.jar, LUCENE-2037.patch
>
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> Now that we're dropping Java 1.4 compatibility for 3.0, we can incorporate Junit4 in testing. Junit3 and junit4 tests can coexist, so no tests should have to be rewritten. We should start this for the 3.1 release so we can get a clean 3.0 out smoothly.
> It's probably worthwhile to convert a small set of tests as an exemplar.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org