lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <>
Subject Re: [jira] Commented: (LUCENE-1844) Speed up junit tests
Date Wed, 25 Nov 2009 19:31:18 GMT
On Wed, Nov 25, 2009 at 1:01 PM, Erick Erickson <> wrote:
> They're ready to go, but at Uwe's suggestion, I've been waiting for 3.0 to
> get settled before prompting someone to apply this patch. I was going to
> generate a new patch for this and for 2037 (junit4 tests) just to make sure
> they were easy to apply. But if you're willing, the patches are already
> attached to the JIRA issues. Do note that the decision in
> MinBooleanShouldMatch to stop checking the query after 100 rather than
> checking all 1,000 is included in the patch....

Uwe do you still think we should wait?  3.0.0 looks like it's "out"?

> Do you want to apply the patches or should I regenerate? It's no big deal to
> regenerate them and I'll have a better feel for reconciling any conflicts. I
> don't know whether there even *are* any conflicts, but just in case....

Let's hold up until we hear from Uwe...

> For my info, though, if I have a more recent patch that *replaces* an
> earlier patch, especially one that hasn't yet been applied, is it preferred
> to delete the earlier patch when providing a new one?

Actually in general I prefer people not delete the old patches...
This way if there's a question/confusion we can always go back &
compare old to new.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message