lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2076) Add org.apache.lucene.store.FSDirectory.getDirectory()
Date Tue, 17 Nov 2009 19:38:40 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779077#action_12779077
] 

Mark Miller commented on LUCENE-2076:
-------------------------------------

Perhaps getDir or something then? Not a fan of getFile either - its going to return a directory,
and while I know a File can be either, getDir or getDirectory are more descriptive as to what
you are getting. I don't even think getDirectory is a problem myself - it returns a File,
so its pretty clear its not a Lucene Directory - we have an issue there no matter - a file
system directory came around quite a bit before a Lucene Directory :)

> Add org.apache.lucene.store.FSDirectory.getDirectory()
> ------------------------------------------------------
>
>                 Key: LUCENE-2076
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2076
>             Project: Lucene - Java
>          Issue Type: Wish
>          Components: Store
>    Affects Versions: 3.0
>            Reporter: George Aroush
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: FSDirectory.patch
>
>
> On the Apache Lucene.Net side, we have done some clean up with the upcoming 2.9.1 such
that we are now depreciating improperly use of parameter type for some public APIs.  When
we release 3.0, those depreciated code will be removed.
> One area where we had difficulty with required us to add a new method like so: Lucene.Net.Store.FSDirectory.GetDirectory().
 This method does the same thing as Lucene.Net.Store.FSDirectory.GetFile().  This was necessary
because we switched over from using System.IO.FileInfo to System.IO.DirectoryInfo.  Why? 
In the .NET world, a file and a directory are two different things.
> Why did we have to add Lucene.Net.Store.FSDirectory.GetDirectory()?  Because we can't
change the return type of Lucene.Net.Store.FSDirectory.GetFile() and still remain backward
compatible (API wise) to be depreciated with the next release.
> Why ask for Java Lucene to add org.apache.lucene.store.FSDirectory.getDirectory()?  To
keep the APIs 1-to-1 in par with Java Lucene and Lucene.Net.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message