lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] Updated: (LUCENE-2012) Add @Override annotations
Date Sun, 08 Nov 2009 12:27:32 GMT


Robert Muir updated LUCENE-2012:

    Attachment: LUCENE-2012_contrib.patch

there were some places where @override was added for generated code (snowball, javacc), I
excluded these files, as was done for core.

also add @override for demo. will commit and resolve this soon as this will quickly get out
of date.

> Add @Override annotations
> -------------------------
>                 Key: LUCENE-2012
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Uwe Schindler
>             Fix For: 3.0
>         Attachments: LUCENE-2012-tests.patch, LUCENE-2012.patch, LUCENE-2012_contrib.patch,
> During removal of deprecated APIs, mostly the problem was, to not only remove the method
in the (abstract) base class (e.g. Scorer.explain()), but also remove it in sub classes that
override it. You can easily forget that (especially, if the method was not marked deprecated
in the subclass). By adding @Override annotations everywhere in Lucene, such removals are
simple, because the compiler throws out an error message in all subclasses which then no longer
override the method.
> Also it helps preventing the well-known traps like overriding hashcode() instead of hashCode().
> The patch was generated automatically, and is rather large. Should I apply it, or would
it break too many patches (but I think, trunk has changed so much, that this is only a minimum
of additional work to merge)?

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message