lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Johan Kindgren (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1260) Norm codec strategy in Similarity
Date Tue, 10 Nov 2009 06:00:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775310#action_12775310
] 

Johan Kindgren commented on LUCENE-1260:
----------------------------------------

Regarding the performance of the TermScorer, there could be two things to handle to ensure
that the Jvm will inline the code: 
1. In the Scorer base-class, make the field 'similarity' final. (Shouldn't be any problem
since it's imutable?)
2. In the Similarity, make the internal decoder array final. That's really up to the implementor,
but the default implementations should perhaps use a final field. Also add a note in the javadoc
of this?
Would you like me to create another patch with the above changes? Maybe there could other
optimizations, haven't really looked at optimizing the code yet.

> Norm codec strategy in Similarity
> ---------------------------------
>
>                 Key: LUCENE-1260
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1260
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.3.1
>            Reporter: Karl Wettin
>            Assignee: Michael McCandless
>             Fix For: 3.1
>
>         Attachments: Lucene-1260.patch, LUCENE-1260.txt, LUCENE-1260.txt, LUCENE-1260.txt
>
>
> The static span and resolution of the 8 bit norms codec might not fit with all applications.

> My use case requires that 100f-250f is discretized in 60 bags instead of the default..
10?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message