lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2052) Scan method signatures and add varargs where possible
Date Sat, 14 Nov 2009 09:31:40 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777851#action_12777851
] 

Uwe Schindler commented on LUCENE-2052:
---------------------------------------

Yes, that's right. For stopwords a varargs ctor is not really "the right thing". Varargs are
more for cases like instantiating a MultiReader with 5 IndexReaders or something like that.
Or adding a bunch of clauses to a SpanQuery.
The varargs Set<?> is one unit, arrays are not needed (they are there because of BW
compatibility). All these ctors except Set<?> should have been deprecated in 2.9.

> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
>                 Key: LUCENE-2052
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2052
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.0
>
>         Attachments: LUCENE-2052.patch, LUCENE-2052.patch, LUCENE-2052_fa.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader
and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards
break, they stay arrays as before.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message