lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <>
Subject [jira] Commented: (LUCENE-2041) Complete parallelizaton of ParallelMultiSearcher
Date Fri, 06 Nov 2009 23:44:32 GMT


Simon Willnauer commented on LUCENE-2041:

Hey Joey, 
good to see you coming up with patches, nice that you catch up on that TODO. You added support
for parallel DocFreq which is good! Did you think about using an interface from the new concurrent
utils instead of subclassing thread? I would like to see people using the new features which
make code slightly more readable too. You would be able to simply throw the exception in the
Callable#call() method and retrieve it once it has terminated.
you could also use a Pooled Executor to run those threads so you don't have to spawn them
each time you call docFreq on the multi searcher.

one more thing, your patch is hard to read as you formated the source code. please try to
do not format it - that would make it way easier to read and see what has been added  / changed.

> Complete parallelizaton of ParallelMultiSearcher
> ------------------------------------------------
>                 Key: LUCENE-2041
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Joey Surls
>            Priority: Minor
>             Fix For: 3.0
>         Attachments: LUCENE-2041.patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> ParallelMultiSearcher is parallel only for the method signatures of 'search'.
> Part of a query process calls the method docFreq(). There was a TODO comment to parallelize
this. Parallelizing this method actually increases the performance of a query on multiple
indexes, especially remotely.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message