lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <>
Subject [jira] Updated: (LUCENE-2068) fix reverseStringFilter for unicode 4.0
Date Mon, 16 Nov 2009 16:59:39 GMT


Simon Willnauer updated LUCENE-2068:

    Attachment: LUCENE_2068.patch

Robert, I cleaned up the patch a little and did some minor optimizations.
I replace the ugly surrogatePair checks with the JDKs version. This method call will be inlined

I  added some JavaDoc comments as well. I guess this is good to go once 3.1 is out. 

> fix reverseStringFilter for unicode 4.0
> ---------------------------------------
>                 Key: LUCENE-2068
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Priority: Minor
>             Fix For: 3.1
>         Attachments: LUCENE-2068.patch, LUCENE_2068.patch
> ReverseStringFilter is not aware of supplementary characters: when it reverses it will
create unpaired surrogates, which will be replaced by U+FFFD by the indexer (but not at query
> The wrong words will conflate to each other, and the right words won't match, basically
the whole thing falls apart.
> This patch implements in-place reverse with the algorithm from apache harmony AbstractStringBuilder.reverse0()

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message