lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2051) Contrib Analyzer Setters should be deprecated and replace with ctor arguments
Date Sat, 14 Nov 2009 23:30:39 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778018#action_12778018
] 

Uwe Schindler commented on LUCENE-2051:
---------------------------------------

I will create an RC, as soon as we have the remaining issues closed (hopefully soon), ideally
at the beginning of the week! Some remaining issues (like changing BW requirements) are not
really release critical. Also the change of sysreq page.

I think only your's, Mike's with default readonly ctors and maybe the N-Gram one are important.

> Contrib Analyzer Setters should be deprecated and replace with ctor arguments
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-2051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2051
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>    Affects Versions: 2.9.1
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 3.0
>
>
> Some analyzers in contrib provide setters for stopword / stem exclusion sets / hashtables
etc. Those setters should be deprecated as they yield unexpected behaviour. The way they work
is they set the reusable token stream instance to null in a thread local cache which only
affects the tokenstream in the current thread. Analyzers itself should be immutable except
of the threadlocal. 
> will attach a patch soon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message