lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] Updated: (LUCENE-2057) TopDocsCollector should not be declared with generic <T>
Date Wed, 11 Nov 2009 19:54:39 GMT


Uwe Schindler updated LUCENE-2057:

    Attachment: scoredoc.patch

The patch is already finished and ready to commit.

> TopDocsCollector should not be declared with generic <T>
> --------------------------------------------------------
>                 Key: LUCENE-2057
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>            Reporter: Shai Erera
>             Fix For: 3.0
>         Attachments: scoredoc.patch
> TopDocsCollector was changed to be TopDocsCollector<T>. However it has methods
which specifically assume the PQ stores ScoreDoc. Therefore, if someone extends it and defines
a type which is not ScoreDoc, things will break.
> We shouldn't put <T> on TopDocsCollector at all, but rather change its ctor to
*protected TopDocsCollector(PriorityQueue<? extends ScoreDoc> pq)*. TopDocsCollector
should handle ScoreDoc types. If we do this, we'll need to change FieldValueHitQueue's Entry
to extend ScoreDoc as well.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message