lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] Resolved: (LUCENE-2030) CachingSpanFilter synchronizing on a none final protected object
Date Sun, 08 Nov 2009 21:47:32 GMT


Uwe Schindler resolved LUCENE-2030.

       Resolution: Fixed
    Fix Version/s:     (was: 3.1)

Committed revision: 833934

> CachingSpanFilter synchronizing on a none final protected object
> ----------------------------------------------------------------
>                 Key: LUCENE-2030
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Simon Willnauer
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.0
>         Attachments: LUCENE-2030.patch, LUCENE-2030.patch, LUCENE-2030.patch, LUCENE-2030.patch
> CachingSpanFilter and CachingWrapperFilter expose their internal cache via a protected
member which is lazily instantiated in the getDocSetId method. The current code yields the
chance to double instantiate the cache and internally synchronizes on a protected none final
member. My first guess is that this member was exposed for testing purposes so it should rather
be changed to package private. 
> This patch breaks backwards compat while I guess the cleanup is kind of worth breaking

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message