Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: pass (nike.apache.org: domain of simon.willnauer@googlemail.com
 designates 209.85.220.206 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=mime-version:reply-to:date:message-id:subject:from:to:content-type;
        b=rL5ZV+irX8fdVclhCHQX2hj8S6p1DqYm27JUFICHL7d+n/Bqwj6fNWE8g8s2ZSrF7Z
         Dsw95MtB/CFrlegVZBG7iVJHY2A6fDp/CdzcRskoZ53gZXzT0ng4TqDd/Lv2jxi7e+Vo
         IMMYYwmsduuYJlTB4EyiPfHrHF/kfNT6FjqSs=
MIME-Version: 1.0
Reply-To: simon.willnauer@gmail.com
Date: Sat, 10 Oct 2009 21:26:43 +0200
Message-ID: <f18c9dde0910101226i55f991c4u7f29c74270827b77@mail.gmail.com>
Subject: Change HashSet to Set in WordlistLoader - BackCompat Issue
From: Simon Willnauer <simon.willnauer@googlemail.com>
To: java-dev@lucene.apache.org
Content-Type: text/plain; charset=UTF-8

Hey there,

in the context of https://issues.apache.org/jira/browse/LUCENE-1967 I
was looking at org.apache.lucene.analysis.WordlistLoader. I noticed
that all static methods return HashSet / HashMap instead of their
corresponding interfaces Map / Set. As I'm going to add another static
helper to this class I was wondering if we should change the concrete
impl. to interface return values.
I guess this would break back-compat. for 3.0 so would it make sense
to mark the current static methods as deprecated and add new ones or
should we just keep it as it is while not being best practice though.

simon

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org