Return-Path: 
 <java-dev-return-41889-apmail-lucene-java-dev-archive=lucene.apache.org@lucene.apache.org>
Delivered-To: apmail-lucene-java-dev-archive@www.apache.org
Received: (qmail 35611 invoked from network); 30 Oct 2009 04:55:22 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 30 Oct 2009 04:55:22 -0000
Received: (qmail 90567 invoked by uid 500); 30 Oct 2009 04:55:22 -0000
Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org
Received: (qmail 90452 invoked by uid 500); 30 Oct 2009 04:55:21 -0000
Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:java-dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:java-dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:java-dev@lucene.apache.org>
List-Id: <java-dev.lucene.apache.org>
Reply-To: java-dev@lucene.apache.org
Delivered-To: mailing list java-dev@lucene.apache.org
Received: (qmail 90444 invoked by uid 99); 30 Oct 2009 04:55:21 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Oct 2009 04:55:21 +0000
X-ASF-Spam-Status: No, hits=-10.5 required=5.0
	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Oct 2009 04:55:19 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 6544F234C045
	for <java-dev@lucene.apache.org>; Thu, 29 Oct 2009 21:54:59 -0700 (PDT)
Message-ID: <854747159.1256878499400.JavaMail.jira@brutus>
Date: Fri, 30 Oct 2009 04:54:59 +0000 (UTC)
From: "Uwe Schindler (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-2021) French elision filter should use
 CharArraySet
In-Reply-To: <1863001783.1256874839465.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/LUCENE-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771776#action_12771776 ] 

Uwe Schindler commented on LUCENE-2021:
---------------------------------------

The setArticles method could check with instanceof, if the supplied set is a chararrayset and use it directly (see StopFilter). Otherwise looks good.

> French elision filter should use CharArraySet
> ---------------------------------------------
>
>                 Key: LUCENE-2021
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2021
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: LUCENE-2021.patch
>
>
> French elision filter creates new strings, lowercases them, etc just to check against a Set<String>.
> trivial patch to use chararrayset instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org