Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 42090 invoked from network); 7 Oct 2009 18:31:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 7 Oct 2009 18:31:56 -0000 Received: (qmail 86382 invoked by uid 500); 7 Oct 2009 18:31:55 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 86314 invoked by uid 500); 7 Oct 2009 18:31:55 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 86230 invoked by uid 99); 7 Oct 2009 18:31:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Oct 2009 18:31:55 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Oct 2009 18:31:52 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4D873234C1EC for ; Wed, 7 Oct 2009 11:31:31 -0700 (PDT) Message-ID: <55336048.1254940291302.JavaMail.jira@brutus> Date: Wed, 7 Oct 2009 11:31:31 -0700 (PDT) From: "Luis Alves (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-1937) Add more methods to manipulate QueryNodeProcessorPipeline elements In-Reply-To: <1852590773.1254417383596.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763176#action_12763176 ] Luis Alves commented on LUCENE-1937: ------------------------------------ Hi Adriano, Wouldn't it be better for the pipeline to implement the "List" interface. What do you think? > Add more methods to manipulate QueryNodeProcessorPipeline elements > ------------------------------------------------------------------ > > Key: LUCENE-1937 > URL: https://issues.apache.org/jira/browse/LUCENE-1937 > Project: Lucene - Java > Issue Type: Improvement > Components: contrib/* > Affects Versions: 2.9 > Reporter: Adriano Crestani > Assignee: Adriano Crestani > Priority: Minor > Fix For: 3.1 > > Attachments: LUCENE-1937.patch > > > QueryNodeProcessorPipeline allows the user to define a list of processors to process a query tree. However, it's not very flexible when the user wants to extend/modify an already created pipeline, because it only provides an add method, which only allows the user to append a new processor to the pipeline. > So, I propose to add new methods to manipulate the processor in a pipeline. I think the methods should not consider an index position when modifying the pipeline, hence the index position in a pipeline does not mean anything, a processor has a meaning when it's after or before another processor. Therefore, I suggest the methods should always consider another processor when inserting/modifying the pipeline. For example, insertAfter(processor, newProcessor), which will insert the "newProcessor" after the "processor". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org