Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <1495700079.1256837879447.JavaMail.jira@brutus>
Date: Thu, 29 Oct 2009 17:37:59 +0000 (UTC)
From: =?utf-8?Q?C=C3=A9drik_LIME_=28JIRA=29?= <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-2015) ASCIIFoldingFilter: expose folding
 logic + small improvements to ISOLatin1AccentFilter
In-Reply-To: <1166542840.1256835779760.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/LUCENE-2015?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D127=
71496#action_12771496 ]=20

C=C3=A9drik LIME commented on LUCENE-2015:
-------------------------------------

Robert,

All I did is refactor the big switch(c) into its own method:
  public static final int foldToASCII(char c, char[] output, int outputPos)
and change the caller (public void foldToASCII(char[] input, int length)) a=
ccordingly.

I can submit a patch without formatting changes, but that means the source =
won't be nicely indented...
Please advise.

As for the ISOLatin1AccentFilter patch, it really is to enable us to remove=
 a workaround for an issue we had with some special (yet frequent) chars. F=
eel free to ignore it should you think this part is not relevant.

> ASCIIFoldingFilter: expose folding logic + small improvements to ISOLatin=
1AccentFilter
> -------------------------------------------------------------------------=
-------------
>
>                 Key: LUCENE-2015
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2015
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: C=C3=A9drik LIME
>            Priority: Minor
>         Attachments: Filters.patch
>
>
> This patch adds a couple of non-ascii chars to ISOLatin1AccentFilter (nam=
ely: left & right single quotation marks, en dash, em dash) which we very f=
requently encounter in our projects. I know that this class is now deprecat=
ed; this improvement is for legacy code that hasn't migrated yet.
> It also enables easy access to the ascii folding technique use in ASCIIFo=
ldingFilter for potential re-use in non-Lucene-related code.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org