Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 29810 invoked from network); 27 Oct 2009 14:38:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Oct 2009 14:38:23 -0000 Received: (qmail 50162 invoked by uid 500); 27 Oct 2009 14:38:22 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 50079 invoked by uid 500); 27 Oct 2009 14:38:22 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 50071 invoked by uid 99); 27 Oct 2009 14:38:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2009 14:38:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2009 14:38:20 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 749BD234C046 for ; Tue, 27 Oct 2009 07:37:59 -0700 (PDT) Message-ID: <1399824831.1256654279476.JavaMail.jira@brutus> Date: Tue, 27 Oct 2009 14:37:59 +0000 (UTC) From: "Mark Miller (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Issue Comment Edited: (LUCENE-2011) Remove deprecated Scorer.explain(int) method In-Reply-To: <1313212265.1256642339367.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770525#action_12770525 ] Mark Miller edited comment on LUCENE-2011 at 10/27/09 2:37 PM: --------------------------------------------------------------- Its because of the loss of whats going on in PayloadTermQuery - we also lose some custom info from PayloadNearQuery - on first blush it seems best just to leave the exp in the scorer for Span queries - its still gone from Scorer so I don't see it as much of a problem myself - havn't thought on it much yet though. I guess we could pull all that custom info up to the weight through the span/payload stuff - but then each has to duplicate a bunch of the info from the SpanWeight - it seems nicer just to leave things as they are, let the Scorer do it, and cast. What do you think? was (Author: markrmiller@gmail.com): Its because of the loss of whats going on in PayloadTermQuery - we also lose some custom info from PayloadNearQuery - on first blush it seems best just to leave the exp in the scorer for Span queries - its still gone from Scorer so I don't see it as much of a problem myself - havn't thought on it much yet though. > Remove deprecated Scorer.explain(int) method > -------------------------------------------- > > Key: LUCENE-2011 > URL: https://issues.apache.org/jira/browse/LUCENE-2011 > Project: Lucene - Java > Issue Type: Task > Components: Search > Reporter: Uwe Schindler > Fix For: 3.0 > > Attachments: LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch, LUCENE-2011.patch > > > This is the only remaining deprecation in core, but is not so easy to handle, because lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the explain method has to be moved from Scorer to the Weight. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org