Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <1309900984.1255908631304.JavaMail.jira@brutus>
Date: Sun, 18 Oct 2009 16:30:31 -0700 (PDT)
From: "Robert Muir (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-1257) Port to Java5
In-Reply-To: <926927359.1207125024848.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/LUCENE-1257?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D127=
67158#action_12767158 ]=20

Robert Muir commented on LUCENE-1257:
-------------------------------------

Uwe, I agree. I think if we want to improve this reusability in the future,=
 we should look at doing something similar to what Shai Erera proposed, a s=
ubclass of Analyzer that does the common SavedStreams behavior.

But I think Analyzer should still have Object, so the special cases like Qu=
eryAutoStopWord can be implemented.

> Port to Java5
> -------------
>
>                 Key: LUCENE-1257
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1257
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis, Examples, Index, Other, Query/Scoring, Que=
ryParser, Search, Store, Term Vectors
>    Affects Versions: 3.0
>            Reporter: C=C3=A9dric Champeau
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: instantiated_fieldable.patch, java5.patch, LUCENE-12=
57-BooleanQuery.patch, LUCENE-1257-BooleanScorer_2.patch, LUCENE-1257-Buffe=
redDeletes_DocumentsWriter.patch, LUCENE-1257-CheckIndex.patch, LUCENE-1257=
-CompoundFileReaderWriter.patch, LUCENE-1257-ConcurrentMergeScheduler.patch=
, LUCENE-1257-DirectoryReader.patch, LUCENE-1257-DisjunctionMaxQuery-more_t=
ype_safety.patch, LUCENE-1257-DocFieldProcessorPerThread.patch, LUCENE-1257=
-Document.patch, LUCENE-1257-IndexDeleter.patch, LUCENE-1257-IndexDeletionP=
olicy_IndexFileDeleter.patch, LUCENE-1257-iw.patch, LUCENE-1257-NormalizeCh=
arMap.patch, LUCENE-1257-o.a.l.util.patch, LUCENE-1257-org_apache_lucene_do=
cument.patch, LUCENE-1257-org_apache_lucene_document.patch, LUCENE-1257-org=
_apache_lucene_document.patch, LUCENE-1257-SegmentInfos.patch, LUCENE-1257-=
StringBuffer.patch, LUCENE-1257-StringBuffer.patch, LUCENE-1257-StringBuffe=
r.patch, LUCENE-1257-WordListLoader.patch, LUCENE-1257_BooleanFilter_Generi=
cs.patch, LUCENE-1257_messages.patch, LUCENE-1257_o.a.l.queryParser.patch, =
LUCENE-1257_o.a.l.store.patch, LUCENE-1257_o_a_l_index_test.patch, LUCENE-1=
257_o_a_l_index_test.patch, LUCENE-1257_o_a_l_search.patch, LUCENE-1257_o_a=
_l_search_spans.patch, LUCENE-1257_org_apache_lucene_index.patch, LUCENE-12=
57_org_apache_lucene_index.patch, lucene1257surround1.patch, lucene1257surr=
ound1.patch, o.a.l.analysis.patch, shinglematrixfilter_generified.patch
>
>
> For my needs I've updated Lucene so that it uses Java 5 constructs. I kno=
w Java 5 migration had been planned for 2.1 someday in the past, but don't =
know when it is planned now. This patch against the trunk includes :
> - most obvious generics usage (there are tons of usages of sets, ... Thos=
e which are commonly used have been generified)
> - PriorityQueue generification
> - replacement of indexed for loops with for each constructs
> - removal of unnececessary unboxing
> The code is to my opinion much more readable with those features (you act=
ually *know* what is stored in collections reading the code, without the ne=
ed to lookup for field definitions everytime) and it simplifies many algori=
thms.
> Note that this patch also includes an interface for the Query class. This=
 has been done for my company's needs for building custom Query classes whi=
ch add some behaviour to the base Lucene queries. It prevents multiple unnn=
ecessary casts. I know this introduction is not wanted by the team, but it =
really makes our developments easier to maintain. If you don't want to use =
this, replace all /Queriable/ calls with standard /Query/.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org