lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon Willnauer <simon.willna...@googlemail.com>
Subject Change HashSet to Set in WordlistLoader - BackCompat Issue
Date Sat, 10 Oct 2009 19:26:43 GMT
Hey there,

in the context of https://issues.apache.org/jira/browse/LUCENE-1967 I
was looking at org.apache.lucene.analysis.WordlistLoader. I noticed
that all static methods return HashSet / HashMap instead of their
corresponding interfaces Map / Set. As I'm going to add another static
helper to this class I was wondering if we should change the concrete
impl. to interface return values.
I guess this would break back-compat. for 3.0 so would it make sense
to mark the current static methods as deprecated and add new ones or
should we just keep it as it is while not being best practice though.

simon

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message