lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DM Smith <dmsmith...@gmail.com>
Subject Re: svn commit: r821434 - /lucene/java/trunk/src/java/org/apache/lucene/search/Searcher.java
Date Sun, 04 Oct 2009 01:02:22 GMT
On Oct 3, 2009, at 6:56 PM, Mark Miller <markrmiller@gmail.com> wrote:

> No bug fixes for the lazy!
Not having 1.5 on mac osx tiger is the issue. Dou you recommend that  
2.9.0 is really not for 1.4 users. Therefore was no point in waiting  
on Java1.5.
>
> :)

Yes I see that tongue in your cheek.


>
> We should also fix Hits then - how about something like:
>
> * @deprecated
> * see {@link Searcher#search(Query, int)} and {@link
> Searcher#search(Query, Sort)}
> * as well as the variants that take a {@link Filter} :<br>
> * <pre>
> *   TopDocs topDocs = searcher.search(query, numHits);
> *   ScoreDoc[] hits = topDocs.scoreDocs;
> *   for (int i = 0; i < hits.length; i++) {
> *     int docId = hits[i].doc;
> *     Document d = searcher.doc(docId);
> *     // do something with current hit
> *     ...
> * </pre>
> */
Yes bad docs should be fixed! Add deprecations, as they were missed.

--DM
> Michael Busch wrote:
>> On 10/4/09 12:42 AM, Mark Miller wrote:
>>> Why will 3.0 be work to upgrade? 2.9 was supposed to be the work,  
>>> 3.0 no
>>> work ...
>>>
>>
>> With 2.9 you can be lazy and live with deprecation warnings. With 3.0
>> you *have* to switch to undeprecated APIs.
>>
>> Michael
>>
>>> In either case, I don't mind a 2.9.1 - but it hadn't been planned  
>>> yet
>>> that I saw.
>>>
>>> Michael Busch wrote:
>>>
>>>> Should we fix these kind of things in the 2.9 branch too?
>>>> I'm 99.9% sure we'll have a 2.9.1 release - 3.0 will be a bunch of
>>>> work for users to upgrade, so we should definitely deliver a bugfix
>>>> release for 2.9, even if we (hopefully) only find minor bugs.
>>>>
>>>>  Michael
>>>>
>>>> On 10/4/09 12:14 AM, markrmiller@apache.org wrote:
>>>>
>>>>> Author: markrmiller
>>>>> Date: Sat Oct  3 22:14:18 2009
>>>>> New Revision: 821434
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=821434&view=rev
>>>>> Log:
>>>>> don't point to deprecated method
>>>>>
>>>>> Modified:
>>>>>
>>>>> lucene/java/trunk/src/java/org/apache/lucene/search/Searcher.java
>>>>>
>>>>> Modified:
>>>>> lucene/java/trunk/src/java/org/apache/lucene/search/Searcher.java
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/search/Searcher.java?rev=821434&r1=821433&r2=821434&view=diff
>>>>>
>>>>>
>>>>> === 
>>>>> === 
>>>>> === 
>>>>> === 
>>>>> ==================================================================
>>>>>
>>>>>
>>>>> --- lucene/java/trunk/src/java/org/apache/lucene/search/ 
>>>>> Searcher.java
>>>>> (original)
>>>>> +++ lucene/java/trunk/src/java/org/apache/lucene/search/ 
>>>>> Searcher.java
>>>>> Sat Oct  3 22:14:18 2009
>>>>> @@ -118,7 +118,7 @@
>>>>>     *
>>>>>     *<p>Applications should only use this if they need<i>all</i>
>>>>> of the
>>>>>     * matching documents.  The high-level search API ({@link
>>>>> -  * Searcher#search(Query)}) is usually more efficient, as it  
>>>>> skips
>>>>> +  * Searcher#search(Query, int)}) is usually more efficient, as  
>>>>> it
>>>>> skips
>>>>>     * non-high-scoring hits.
>>>>>     *<p>Note: The<code>score</code>   passed to this
method is a  
>>>>> raw
>>>>> score.
>>>>>     * In other words, the score will not necessarily be a float  
>>>>> whose
>>>>> value is
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> --- 
>>>> ------------------------------------------------------------------
>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>>
>>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>
>
> -- 
> - Mark
>
> http://www.lucidimagination.com
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message