lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: [jira] Updated: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
Date Mon, 19 Oct 2009 19:51:48 GMT
On Mon, Oct 19, 2009 at 3:11 PM, Mark Miller <markrmiller@gmail.com> wrote:
> Uwe Schindler (JIRA) wrote:
>>
>> And please: next time when we deprecate APIs: remove all deprecated calls from tests
and contrib and mark all deprecated-test as such!
>>
>>
> Its the nature of open source. Each of us takes the work that other
> contributors are willing/able/havetime to provide - and fill in the rest
> ourselves or decide its too much work and don't. I agree that its a nice
> idea, but I don't think the issue is going away so easily myself ;) In
> which case it falls to the poor soul who decides to help later and
> remove the deprecated methods. Or perhaps it keeps someone from stepping
> up and doing that - nature of the beast.

I do agree this is the nature of the beast.

Also, thinking more about it... I think a good approach, for an issue
with a large number of deprecations, might be to open a separate issue
to fix the deprecations in contrib/test, and fix it after some delay.
This way we confirm that deprecated usage of the APIs is working, for
at least some time, before removing them all from the tests.

EG in LUCENE-1458 I waited until quite late to cutover usage to the flex API.

> But as long as we are making such requests, please no one commit any
> more funky source formatting either :) It hurts my eyes.

+1!

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message