lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Wang <john.w...@gmail.com>
Subject Re: 2.9.1
Date Sat, 17 Oct 2009 17:16:36 GMT
Oh ok. I was thinking that if term is not null, termDocs(Term) would be
called.
-John

On Sat, Oct 17, 2009 at 10:12 AM, Michael McCandless <
lucene@mikemccandless.com> wrote:

> I think this code is correct?  The null is forwarded so SegmentReader
> returns AllDocsEnum.
>
> Mike
>
> On Sat, Oct 17, 2009 at 1:09 PM, John Wang <john.wang@gmail.com> wrote:
> > In DirectoryReader$MultiTermDocs implementation:
> > in method:  protected TermDocs termDocs(IndexReader reader)
> > return term==null ? reader.termDocs(null) : reader.termDocs();
> > Is this correct?
> > Shouldn't it be:
> > return term==null ? reader.termDocs() : reader.termDocs(term);
> >
> > Thanks
> > -John
> >
> > On Sat, Oct 17, 2009 at 8:11 AM, Yonik Seeley <
> yonik@lucidimagination.com>
> > wrote:
> >>
> >> On Wed, Oct 14, 2009 at 5:39 PM, Michael McCandless
> >> <lucene@mikemccandless.com> wrote:
> >> > I can cut the 2.9.1 release, but... should we wait a bit to see
> >> > whether other issues come up?
> >>
> >> I took a quick peek at the test code provided by Peter... and this
> >> certainly looks like a bug:
> >> https://issues.apache.org/jira/browse/LUCENE-1986
> >>
> >> I'm heads down on the Solr release right now though, so I haven't had
> >> time to dig in.
> >>
> >> -Yonik
> >> http://www.lucidimagination.com
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> >> For additional commands, e-mail: java-dev-help@lucene.apache.org
> >>
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>

Mime
View raw message