lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Bennett (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1636) TokenFilters with a null value in the constructor fail
Date Mon, 05 Oct 2009 18:04:31 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762281#action_12762281
] 

Mark Bennett commented on LUCENE-1636:
--------------------------------------

(trouble posting, forgive if duplicate)
This change also broke the Japanese morphological SEN / Lucene integration code in lucene-ja.
 Since Solr 1.4 is based on Lucene 2.9, this will also effectively break SEN for Solr users
who upgrade to 1.4.

I'm not complaining.  Reading the above comments, the change was probably the "right" thing
to do.  I've contacted the author of lucene-ja, and I hope to work on a rewrite to address
this.

I would be interested in any comments you folks might have about the lucene-ja code.

Class org.apache.lucene.analysis.ja.POSFilter
Extends org.apache.lucene.analysis.TokenFilter

Offending code in lucene-ja's POSFilter
    public POSFilter(TokenStream in, Hashtable posTable) {
        super(in);
        input = in; // <<==== this is a member field of parent TokenFilter
        table = posTable;
    }
This is done in several classes.

> TokenFilters with a null value in the constructor fail
> ------------------------------------------------------
>
>                 Key: LUCENE-1636
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1636
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.9
>            Reporter: Wouter Heijke
>            Assignee: Michael McCandless
>             Fix For: 2.9
>
>         Attachments: LUCENE-1636.patch
>
>
> While migrating from 2.4.x to 2.9-dev I found a lot of failing unittests.
> One problem is with TokenFilters that do a super(null) in the constructor.
> I fixed it by changing the constructor to super(new EmptyTokenStream())
> This will cause problems and frustration to others while migrating to 2.9.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message