lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cédrik LIME (JIRA) <>
Subject [jira] Commented: (LUCENE-2015) ASCIIFoldingFilter: expose folding logic + small improvements to ISOLatin1AccentFilter
Date Thu, 29 Oct 2009 18:55:59 GMT


Cédrik LIME commented on LUCENE-2015:

Indeed, and that was my primary (internal) patch.
But then you loose the shared "output" buffer between incrementToken() calls, and you end
up creating char[]'s like there is no tomorrow, which may be a performance regression.

What I can do is /add/ a static method that operates on a char[], for convenient external
What do you think?

> ASCIIFoldingFilter: expose folding logic + small improvements to ISOLatin1AccentFilter
> --------------------------------------------------------------------------------------
>                 Key: LUCENE-2015
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Cédrik LIME
>            Priority: Minor
>         Attachments: ASCIIFoldingFilter-no_formatting.patch, Filters.patch, ISOLatin1AccentFilter.patch
> This patch adds a couple of non-ascii chars to ISOLatin1AccentFilter (namely: left &
right single quotation marks, en dash, em dash) which we very frequently encounter in our
projects. I know that this class is now deprecated; this improvement is for legacy code that
hasn't migrated yet.
> It also enables easy access to the ascii folding technique use in ASCIIFoldingFilter
for potential re-use in non-Lucene-related code.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message