lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler" <...@thetaphi.de>
Subject RE: svn commit: r830866 - /lucene/java/branches/lucene_2_9/src/java/org/apache/lucene/analysis/StopFilter.java
Date Thu, 29 Oct 2009 09:23:12 GMT
Mike:
After looking into this: In the 2.9 branch should this method not return the
ENABLE_POSITION_INCREMENTS_DEFAULT for versions < 2.9? Maybe you had the
id-statement because of this here?

Because the documentation of the deprecated static setter tells you that you
can modify the behaviour of StopFilter embedded in Analyzers like
StandardAnalyzer by this. But if you use the default ctor of
StandardAnalyzer, version 2.4 is used, but no change to change the default.

-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de

> -----Original Message-----
> From: uschindler@apache.org [mailto:uschindler@apache.org]
> Sent: Thursday, October 29, 2009 10:16 AM
> To: java-commits@lucene.apache.org
> Subject: svn commit: r830866 -
> /lucene/java/branches/lucene_2_9/src/java/org/apache/lucene/analysis/StopF
> ilter.java
> 
> Author: uschindler
> Date: Thu Oct 29 09:16:16 2009
> New Revision: 830866
> 
> URL: http://svn.apache.org/viewvc?rev=830866&view=rev
> Log:
> no branching needed, return value of version compare is already boolean
> 
> Modified:
> 
> lucene/java/branches/lucene_2_9/src/java/org/apache/lucene/analysis/StopFi
> lter.java
> 
> Modified:
> lucene/java/branches/lucene_2_9/src/java/org/apache/lucene/analysis/StopFi
> lter.java
> URL:
> http://svn.apache.org/viewvc/lucene/java/branches/lucene_2_9/src/java/org/
> apache/lucene/analysis/StopFilter.java?rev=830866&r1=830865&r2=830866&view
> =diff
> ==========================================================================
> ====
> ---
> lucene/java/branches/lucene_2_9/src/java/org/apache/lucene/analysis/StopFi
> lter.java (original)
> +++
> lucene/java/branches/lucene_2_9/src/java/org/apache/lucene/analysis/StopFi
> lter.java Thu Oct 29 09:16:16 2009
> @@ -251,11 +251,7 @@
>     * or later, it returns true.
>     */
>    public static boolean getEnablePositionIncrementsVersionDefault(Version
> matchVersion) {
> -    if (matchVersion.onOrAfter(Version.LUCENE_29)) {
> -      return true;
> -    } else {
> -      return false;
> -    }
> +    return (matchVersion.onOrAfter(Version.LUCENE_29));
>    }
> 
>    /**
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message