lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Miller <markrmil...@gmail.com>
Subject Re: svn commit: r821434 - /lucene/java/trunk/src/java/org/apache/lucene/search/Searcher.java
Date Sat, 03 Oct 2009 22:59:48 GMT
Whoops - there is no short sort method:

 * @deprecated
 * see {@link Searcher#search(Query, int)}, {@link Searcher#search(Query, Filter, int)}
 * and {@link Searcher#search(Query, Filter, int, Sort)}:<br>
 * <pre>
 *   TopDocs topDocs = searcher.search(query, numHits);
 *   ScoreDoc[] hits = topDocs.scoreDocs;
 *   for (int i = 0; i < hits.length; i++) {
 *     int docId = hits[i].doc;
 *     Document d = searcher.doc(docId);
 *     // do something with current hit
 *     ...
 * </pre>
 */



Mark Miller wrote:
> No bug fixes for the lazy!
>
> :)
>
> We should also fix Hits then - how about something like:
>
>  * @deprecated
>  * see {@link Searcher#search(Query, int)} and {@link
> Searcher#search(Query, Sort)}
>  * as well as the variants that take a {@link Filter} :<br>
>  * <pre>
>  *   TopDocs topDocs = searcher.search(query, numHits);
>  *   ScoreDoc[] hits = topDocs.scoreDocs;
>  *   for (int i = 0; i < hits.length; i++) {
>  *     int docId = hits[i].doc;
>  *     Document d = searcher.doc(docId);
>  *     // do something with current hit
>  *     ...
>  * </pre>
>  */
>
> Michael Busch wrote:
>   
>> On 10/4/09 12:42 AM, Mark Miller wrote:
>>     
>>> Why will 3.0 be work to upgrade? 2.9 was supposed to be the work, 3.0 no
>>> work ...
>>>    
>>>       
>> With 2.9 you can be lazy and live with deprecation warnings. With 3.0
>> you *have* to switch to undeprecated APIs.
>>
>>  Michael
>>
>>     
>>> In either case, I don't mind a 2.9.1 - but it hadn't been planned yet
>>> that I saw.
>>>
>>> Michael Busch wrote:
>>>   
>>>       
>>>> Should we fix these kind of things in the 2.9 branch too?
>>>> I'm 99.9% sure we'll have a 2.9.1 release - 3.0 will be a bunch of
>>>> work for users to upgrade, so we should definitely deliver a bugfix
>>>> release for 2.9, even if we (hopefully) only find minor bugs.
>>>>
>>>>   Michael
>>>>
>>>> On 10/4/09 12:14 AM, markrmiller@apache.org wrote:
>>>>     
>>>>         
>>>>> Author: markrmiller
>>>>> Date: Sat Oct  3 22:14:18 2009
>>>>> New Revision: 821434
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=821434&view=rev
>>>>> Log:
>>>>> don't point to deprecated method
>>>>>
>>>>> Modified:
>>>>>      
>>>>> lucene/java/trunk/src/java/org/apache/lucene/search/Searcher.java
>>>>>
>>>>> Modified:
>>>>> lucene/java/trunk/src/java/org/apache/lucene/search/Searcher.java
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/search/Searcher.java?rev=821434&r1=821433&r2=821434&view=diff
>>>>>
>>>>>
>>>>> ==============================================================================
>>>>>
>>>>>
>>>>> --- lucene/java/trunk/src/java/org/apache/lucene/search/Searcher.java
>>>>> (original)
>>>>> +++ lucene/java/trunk/src/java/org/apache/lucene/search/Searcher.java
>>>>> Sat Oct  3 22:14:18 2009
>>>>> @@ -118,7 +118,7 @@
>>>>>      *
>>>>>      *<p>Applications should only use this if they need<i>all</i>
 
>>>>> of the
>>>>>      * matching documents.  The high-level search API ({@link
>>>>> -  * Searcher#search(Query)}) is usually more efficient, as it skips
>>>>> +  * Searcher#search(Query, int)}) is usually more efficient, as it
>>>>> skips
>>>>>      * non-high-scoring hits.
>>>>>      *<p>Note: The<code>score</code>   passed to this
method is a raw
>>>>> score.
>>>>>      * In other words, the score will not necessarily be a float whose
>>>>> value is
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>        
>>>>>           
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>>
>>>>      
>>>>         
>>>    
>>>       
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>     
>
>
>   


-- 
- Mark

http://www.lucidimagination.com




---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message