lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
Date Mon, 19 Oct 2009 18:53:59 GMT


Michael McCandless commented on LUCENE-1987:

bq. All contrib analyzers have stopWordPosIncr turned off (backwards compatibility). Maybe
we need a Version Parameter in all analyzers there too!

Ugh, this is because they embed StopFilter, right?  One option might be to simply keep StopFilter's
deprecated static methods for setting the default?  Though I think adding Version to them
over time is the right thing to do (though more work, today).

bq. benchmark does not work any longer, because StandardAnalyzer has no default ctor anymore
and cannot be instantiated by reflection, same with StopAnalyzer

When the no-arg ctor is unavailable, can we fallback to looking for a ctor that takes Version?
 For now we should just pass LUCENE_CURRENT; a future enhancement to benchmark can allow specifying
version compat.

bq. The default of QueryParser is to ignore position increments, but the current version of
StandardAnalyzer uses posIncr for stop words

Hmm.  How about adding Version to QP ctor?

bq. And please: next time when we deprecate APIs: remove all deprecated calls from tests and
contrib and mark all deprecated-test as such!

OK, I agree.  I'll try to do this in the future!

> Remove rest of analysis deprecations (Token, CharacterCache)
> ------------------------------------------------------------
>                 Key: LUCENE-1987
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Analysis
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 2.9.1, 3.0
>         Attachments: LUCENE-1987-StopFilter-backport29.patch, LUCENE-1987-StopFilter-BW.patch,
LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch,
LUCENE-1987-StopFilter.patch, LUCENE-1987.patch, LUCENE-1987.patch, LUCENE-1987.patch
> These removes the rest of the deprecations in the analysis package:
> - -Token's termText field-- (DONE)
> - -eventually un-deprecate ctors of Token taking Strings (they are still useful) ->
if yes remove deprec in 2.9.1- (DONE)
> - -remove CharacterCache and use Character.valueOf() from Java5- (DONE)
> - Stopwords lists
> - Remove the backwards settings from analyzers (acronym, posIncr,...). They are deprecated,
but we still have the VERSION constants. Do not know, how to proceed. Keep the settings alive
for index compatibility? Or remove it together with the version constants (which were undeprecated).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message