lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
Date Sun, 18 Oct 2009 12:05:31 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767049#action_12767049
] 

Uwe Schindler edited comment on LUCENE-1987 at 10/18/09 5:04 AM:
-----------------------------------------------------------------

Mike:
You invented the VERSION constants for StandardAnalyzer and so on. How should we handle the
deprecated settings inside? Just remove the get/setters and only use the version constant
to enable the backwards settings? If I remove these settings internally in StopAnalyzer and
StopFilter and Standard*, too, I also have to remove some version support.

How would you proceed?

Furthermore: The "deprecated" check for overridden tokenStream methods to fix this bug, if
somebody subclasses a core-Analyzer, what to do with them. As the tokenStream methods is not
deprecated in favour of reusableTokenStream, how to prevent this in future. Keep this reflection
checks? Or make the Analyzers final?

      was (Author: thetaphi):
    Mike:
You invented the VERSION constants for StandardAnalyzer and so on. How should we handle the
deprecated settings inside? Just remove the get/setters and only use the version constant
to enable the backwards settings? If I remove these settings internally in StopAnalyzer and
StopFilter and Standard*, too, I also have to remove some version support.

How would you proceed?
  
> Remove rest of analysis deprecations (Token, CharacterCache)
> ------------------------------------------------------------
>
>                 Key: LUCENE-1987
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1987
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Analysis
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.0
>
>         Attachments: LUCENE-1987.patch, LUCENE-1987.patch, LUCENE-1987.patch
>
>
> These removes the rest of the deprecations in the analysis package:
> - -Token's termText field-- (DONE)
> - -eventually un-deprecate ctors of Token taking Strings (they are still useful) ->
if yes remove deprec in 2.9.1- (DONE)
> - -remove CharacterCache and use Character.valueOf() from Java5- (DONE)
> - Stopwords lists
> - Remove the backwards settings from analyzers (acronym, posIncr,...). They are deprecated,
but we still have the VERSION constants. Do not know, how to proceed. Keep the settings alive
for index compatibility? Or remove it together with the version constants (which were undeprecated).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message