lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Elschot (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1935) Generify PriorityQueue
Date Fri, 02 Oct 2009 07:23:23 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761492#action_12761492
] 

Paul Elschot commented on LUCENE-1935:
--------------------------------------

> Do you want to provide a patch for ScorerDocQueue that it subclasses PQ<HeapedScorerDoc>?

Yes, however that could also be done at a separate issue.
Thanks for reminding me of the topSkipToAndAdjustElsePop method.
At the time the JIT was not able to fully optimize two method calls to a ScorerDocQueue object,
so I added that method to the class.

Btw. ScorerDocQueue is used in disjunction queries when the docs should be scored in order,
so it is sensitive to query performance, see LUCENE-365 .

> Generify PriorityQueue
> ----------------------
>
>                 Key: LUCENE-1935
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1935
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Other
>    Affects Versions: 2.9
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.0
>
>         Attachments: LUCENE-1935.patch
>
>
> Priority Queue should use generics like all other Java 5 Collection API classes. This
very simple, but makes code more readable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message