lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (LUCENE-2011) Remove deprecated Scorer.explain(int) method
Date Tue, 27 Oct 2009 13:42:59 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770505#action_12770505
] 

Mark Miller edited comment on LUCENE-2011 at 10/27/09 1:42 PM:
---------------------------------------------------------------

Okay, nice - looks like we are pretty similar - you just pulled some more cruft that I didn't
and pulled the phrasequery/spanquery stuff up a level it looks. My hack was to keep them were
they are, make them package private, and just cast the scorer ;)

I'd say lets go with your patch and just fix that test.

      was (Author: markrmiller@gmail.com):
    Okay, nice - looks like we are pretty similar - you just pulled some more cruft that I
didn't and pulled the phrasequery/spanquery stuff up a level it looks. My hack was to keep
them were they are, make them package private, and just cast the scorer ;)
  
> Remove deprecated Scorer.explain(int) method
> --------------------------------------------
>
>                 Key: LUCENE-2011
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2011
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Search
>            Reporter: Uwe Schindler
>             Fix For: 3.0
>
>         Attachments: LUCENE-2011.patch, LUCENE-2011.patch
>
>
> This is the only remaining deprecation in core, but is not so easy to handle, because
lot's of code in core still uses the explain() method in Scorer. So e.g. in PhraseQuery, the
explain method has to be moved from Scorer to the Weight.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message