lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Updated: (LUCENE-1950) Remove autoCommit from IndexWriter
Date Thu, 08 Oct 2009 17:14:31 GMT


Michael McCandless updated LUCENE-1950:

    Attachment: LUCENE-1950.patch

Attached patch.  All tests pass.  This is just the first step, which
is to remove autoCommit from IW's public APIs, and fix all places that
were using those APIs.

Second step is to remove autoCommit from inside IW.

When there were tests testing both aC=false and true, I just remove
the "true" case.  When the test was only testing aC=true, I switched
it to false, and sometimes had to tweak the test (eg to insert calls
to IW.commit) to make it happy.  For one test, when I did this
(TestIndexWriter.testImmediateDiskFullWithThreads) it uncovered a
latent bug in IW where if an IOException is hit on building the cfx
file for flushed doc stores, we were missing a call to

I also removed autoCommit from the alg files in
contrib/benchmark/conf, fixed up the javadocs, and removed some unused

I plan to commit soon!

> Remove autoCommit from IndexWriter
> ----------------------------------
>                 Key: LUCENE-1950
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 3.0
>         Attachments: LUCENE-1950.patch
> IndexWriter's autoCommit is deprecated; in 3.0 it will be hardwired to false.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message