lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-2017) CloseableThreadLocal is now obsolete
Date Thu, 29 Oct 2009 19:11:59 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771566#action_12771566
] 

Uwe Schindler commented on LUCENE-2017:
---------------------------------------

If we would do it that way, we wouldn't need the CloseableThreadLocal at all. Because even
with 1.4 you can do a remove() by simply setting the value to null (internally remove() does
exactly that, see src.java in yor jdk). So CloseableThreadLocal is needed.

About the multiple-Threads closing problem: This does not affect Lucene, as it keeps track,
when it can be closed. If you close it to early it is the same as closing an IndexInput at
the wrong time. So do not worry!

> CloseableThreadLocal is now obsolete
> ------------------------------------
>
>                 Key: LUCENE-2017
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2017
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: C├ędrik LIME
>         Attachments: CloseableThreadLocal.patch
>
>
> Since Lucene 3 depends on Java 5, we can use ThreadLocal#remove() to take care or resource
management.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message