lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1987) Remove rest of analysis deprecations (Token, CharacterCache)
Date Mon, 19 Oct 2009 18:17:59 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767435#action_12767435
] 

Robert Muir commented on LUCENE-1987:
-------------------------------------

bq. All contrib analyzers have stopWordPosIncr turned off (backwards compatibility). Maybe
we need a Version Parameter in all analyzers there too! 

Personally I would not be against this, not sure yet... downside would be more complexity
and maintenance
Upside would be that we could improve these analyzers in various ways, without annoying users

bq. benchmark does not work any longer, because StandardAnalyzer has no default ctor anymore
and cannot be instantiated by reflection, same with StopAnalyzer 
I also personally like having default ctor... its convienient and nice to be able to look
at what these analyzers do in Luke, etc
But I think this goes against the version flag concept? (because if users just set it to LUCENE_CURRENT
then its doing nothing?)
But I wonder if users do this anyway... maybe the default should really be LUCENE_CURRENT,
and if you want the back compat-buggy behavior, the onus is on you as the user to set the
flag right if you don't want to reindex?



> Remove rest of analysis deprecations (Token, CharacterCache)
> ------------------------------------------------------------
>
>                 Key: LUCENE-1987
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1987
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Analysis
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 2.9.1, 3.0
>
>         Attachments: LUCENE-1987-StopFilter-backport29.patch, LUCENE-1987-StopFilter-BW.patch,
LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch, LUCENE-1987-StopFilter.patch,
LUCENE-1987-StopFilter.patch, LUCENE-1987.patch, LUCENE-1987.patch, LUCENE-1987.patch
>
>
> These removes the rest of the deprecations in the analysis package:
> - -Token's termText field-- (DONE)
> - -eventually un-deprecate ctors of Token taking Strings (they are still useful) ->
if yes remove deprec in 2.9.1- (DONE)
> - -remove CharacterCache and use Character.valueOf() from Java5- (DONE)
> - Stopwords lists
> - Remove the backwards settings from analyzers (acronym, posIncr,...). They are deprecated,
but we still have the VERSION constants. Do not know, how to proceed. Keep the settings alive
for index compatibility? Or remove it together with the version constants (which were undeprecated).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message